[Help wanted] Improvement of Python Type Stubs - Update availaible #8111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
Daraan
force-pushed
the
type-hinting-to-dev
branch
2 times, most recently
from
1f0ca19
to
b7df53f
Compare
Daraan
force-pushed
the
type-hinting-to-dev
branch
2 times, most recently
from
77bb709
to
640c076
Compare
Daraan
force-pushed
the
type-hinting-to-dev
branch
from
640c076
to
315c318
Compare
- Refactored command to own pyi file - fixes - formatting & lint rules
small cleanup improvements
squashable
Daraan
force-pushed
the
type-hinting-to-dev
branch
from
315c318
to
4d83a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the continuation of #7787 that added type hints for the carla package.
This PR contains:
carla.Rss*classescarla.adtype hints; also they are only included in the rss build. This needs modification of the setup and some cleaningHow can you contribute:
Carla package
You can use ruff and
--exclude *ad/rss,*ad/mapto exclude the SyntaxError from these two files while they are not addressed or the whole ad subpackage.ad subpackage
adsubpackage.Important
The type stubs for the ad library are only minimally done there are many things missing (top-level functions & attributes), wrong (e.g. overloads) or incomplete. I will not continue the work on the ad subpackage.
On my repo I have a tag with alternative type stubs for ad that can be used to complement the ones in this PR. Those are more complete but lack function signatures and types: https://github.com/Daraan/LunaticAI-Driver-for-CARLA-Simulator/releases/tag/deleted-Alternative-ad-type-stubs
setup.pynot to include rss files into non-rss build (happens when rebuilding without cleaning build dir).If someone has a better idea how to prevent copying of the
source/carla/ad/if one does a normal build after an rss build please feel to share your ideas. I am not sure how far we can go withMANIFEST.infiles. Or doing a more thorough cleanup before.Currently these files will be removed instead keeping them around.
Further contributions
Feel free to make PRs against my fork https://github.com/Daraan/CARLA-Simulator-Fork-DebianFix/tree/type-hinting-to-dev to the
type-hinting-to-devbranch.Where has this been tested?
Possible Drawbacks
This change is